escape the GrapeSwaggerRails.options hash properly in the template #51
Conversation
| visit '/swagger' | ||
| page_options_json = page.evaluate_script("$('html').data('swagger-options')").to_json | ||
| expect(page_options_json).to eq(@options.marshal_dump.to_json) | ||
| end |
There was a problem hiding this comment.
It's a good spec, but it doesn't fail before the code change, you need another one that demonstrates the fix for the bug you're fixing.
There was a problem hiding this comment.
That one should have, I didn't realize that jquery unescapes html entities when processing a data tag. So there was no bug, except that the contents of the <html> tag were difficult to read.
| Please also update CHANGELOG. |
| No bug after all, I'm going to close this. |
| 👍 Is the test useful though? Or do we already have something similar? If not do PR it please. |
| You were already testing that various specific options has correct impacts,
|
| It would, but this is a more specific test. I think it's useful. |
2 participants
The
<%=erb syntax escapes strings for html purposes, which means that the data attribute was receiving a string filled with"s and such. Instead we should use<%==. The produced json will contain double-quotes, so the attribute should be set in single quotes.