Skip to content

Conversation

@davidbrewer
Copy link
Contributor

When you are running Swagger-UI on a server which is not open to external access, the default validation behavior causes an error message to be displayed. This change allows you to set a validator_url option to nil, which suppresses this error message. You could also point to a validator service under your own control.

When you are running Swagger-UI on a server which is not open to external access, the default validation behavior causes an error message to be displayed. This change allows you to set a validator_url option to nil, which suppresses this error message. You could also point to a validator service under your own control.
@@ -1,6 +1,6 @@
### 0.2.1 (Next)

* Your contribution here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this back please for the next person.

@dblock
Copy link
Member

dblock commented Mar 2, 2016

This is good other than the CHANGELOG. I wonder whether we should instead of doing this create a way to passthrough anything to swagger UI and deprecate anything that we already do? There're many more options in https://github.com/swagger-api/swagger-ui.

@davidbrewer
Copy link
Contributor Author

OK, I fixed the CHANGELOG -- sorry about that!

I think that doing a more complete answer that handles passing through the rest of the options would be a great solution -- though, I wonder if there are security implications there that I'm not thinking of. Maybe there should be a whitelist of which options can be passed through or something like that.

If you'd like I can open an issue suggesting that feature. I unfortunately don't have the bandwidth in the near future to implement this more complete feature myself.

dblock added a commit that referenced this pull request Mar 3, 2016
@dblock dblock merged commit 59372ab into ruby-grape:master Mar 3, 2016
@dblock
Copy link
Member

dblock commented Mar 3, 2016

Merged.

Yes, do open a feature request, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants