Support CSS media queries #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Please update https://github.com/ruby-grape/grape-swagger-rails/blob/master/CHANGELOG.md too, via |
…rails into media_queries
…with lots of client js to evaluate
Contributor Author
| Was able to replicate the earlier spec failures by downgrading my FF. Adding Current CI problems look to be 2.0.0 and 1.9.3 gem installation issues. |
Member
| Indeed, sleep is definitely not the way to go. Lets worry about the build separately. |
Member
Member
| Build fixed in #40, disabled animations to avoid the sleeps. |
Contributor Author
| Excellent! Thanks for the quick turnaround and tip off to https://github.com/mikz/rack-no_animations |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Just needed the proper tag