Skip to content

Conversation

@maruware
Copy link

This Pull Request will support to use docExpansion option.

GrapeSwaggerRails.options.doc_expansion = 'list'
@dblock
Copy link
Member

dblock commented Sep 16, 2015

This needs a CHANGELOG entry, README updates and some tests to be merged, please.

@maruware
Copy link
Author

CHANGELOG, README, tests updated.
Check those, please.

@dblock
Copy link
Member

dblock commented Sep 16, 2015

Squash commits please?

CHANGELOG.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See examples below, this should have the PR and your name.

@dblock
Copy link
Member

dblock commented Sep 16, 2015

Minor comments above. Otherwise looks great.

@maruware maruware force-pushed the support_doc_expansion_option branch from 7b7165c to e60adb7 Compare September 17, 2015 03:11
@maruware maruware force-pushed the support_doc_expansion_option branch from e60adb7 to e985c3f Compare September 17, 2015 03:18
@maruware
Copy link
Author

Thank you for the advice. Those points was updated.

@dblock
Copy link
Member

dblock commented Sep 17, 2015

Perfect, thanks.

dblock added a commit that referenced this pull request Sep 17, 2015
@dblock dblock merged commit 0b70202 into ruby-grape:master Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants