Adding an option for providing user theming

[alexagranov]

Just nice to be able to provide my own logo, etc.

[unloved]

seems it's gonna be true with default '' value

[alexagranov]

fixed with commit ca7f116

[dblock]

This would need tests and a CHANGELOG entry to be merged (we're trying to be more disciplined here ;)).

That said, it seems hacky. I wonder whether we'd be better served to refactoring the ERB into partials and to let you assemble a custom index.html.erb yourself out of them. You don't have to use this ERB already, you might as well roll your own that looks the way you want, but we could make it easier to do.

[alexagranov]

Absolutely. It was late and I needed to keep moving. Consider it a
feature request rather than a contribution. ;-)

On Fri, Feb 6, 2015 at 5:44 PM, Daniel Doubrovkine (dB.) @dblockdotorg <
notifications@github.com> wrote:

This would need tests and a CHANGELOG entry to be merged (we're trying to
be more disciplined here ;)).

That said, it seems hacky. I wonder whether we'd be better served to
refactoring the ERB into partials and to let you assemble a custom
index.html.erb yourself out of them. You don't have to use this ERB
already, you might as well roll your own that looks the way you want, but
we could make it easier to do.

—
Reply to this email directly or view it on GitHub
#3 (comment)
.

Alex Agranov
Director/Sr.Engineer
Morphogenic Productions
www.morphogenic.net
www.linkedin.com/in/alexagranov
(917) 509-1856

[alexagranov]

In case you still want to merge, cleaning up my late night sloppiness.

[dblock]

Thanks @alexagranov! I think I'd rather not merge this in favor of a more modular approach as described above. Curious to hear what others think, will let this sit here for a bit.

[pcriv]

+1000!

[alexagranov]

Cleaning this up, just realized I've been committing willy nilly...

[dblock]

@alexagranov Please do consider contributing a better implementation, this would be a very useful feature!