CI: Use 2.5.7, 2.6.5, 2.7.0 #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
LeFnord reviewed Feb 17, 2020
| will close #318 in favour of this one |
| I really appreciate the work on bringing this forward! ✨ |
budnik changed the title budnik changed the title LeFnord approved these changes Feb 18, 2020
| thanks @budnik |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previous attempt to update matrix failed because rubocop version is not fixed so
~> 0.65resolved to version above0.75. I guess it was mistake not to define it as~> 0.65.0Last version of rubocop passing is
0.74so fixing that version.Bumping of rubocop could be addressed in own PR.