Support hashes with string keys #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* [#307](https://github.com/ruby-grape/grape-entity/pull/307): Allow exposures to call methods defined in modules included in an entity [@robertoz-01](https://github.com/robertoz-01).Generated by 🚫 danger |
Before this change the only way I could find to access a hash with string keys was to either convert it to a symbol hash or define methods in the entity. This should at least allow the entire hash to be accessed with string keys yet default to existing behaviour (symbol keys).
| thanks @mhenrixon |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Before this change the only way I could find to access a hash with string keys
was to either convert it to a symbol hash or define methods in the entity.
This should at least allow the entire hash to be accessed with string keys yet default to existing behavior (symbol keys).
If anyone has suggestions for how to improve this I'm all ears. This was just the quickest least intrusive thing I could think of at the time.