Skip to content

Conversation

@fangzhu19880123
Copy link

I want to use like this

expose :config1, merge: true, using: ApplicationEntity expose :config2, merge: true, using: ApplicationEntity

but I must use like this

expose :config1, merge: true, using: ApplicationEntity expose :config2, merge: ->(k, v1, v2) { v2 }, using: ApplicationEntity
@grape-bot
Copy link

grape-bot commented Oct 13, 2018

1 Error
🚫 One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces.
2 Warnings
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.
* [#258](https://github.com/ruby-grape/grape-entity/pull/307): Allow exposures to call methods defined in modules included in an entity [@robertoz-01](https://github.com/robertoz-01).

Here's an example of a CHANGELOG.md entry:

* [#310](https://github.com/ruby-grape/grape-entity/pull/310): Support multiple merge fields - [@fangzhu19880123](https://github.com/fangzhu19880123).

Generated by 🚫 danger

@coveralls
Copy link

coveralls commented Oct 13, 2018

Coverage Status

Coverage increased (+0.01%) to 95.858% when pulling ef6026a on fangzhu19880123:master into 53b2502 on ruby-grape:master.

@LeFnord
Copy link
Member

LeFnord commented Jan 29, 2019

thanks @fangzhu19880123

Copy link
Member

@LeFnord LeFnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants