Skip to content

Conversation

@takkanm
Copy link
Contributor

@takkanm takkanm commented Jun 1, 2017

No description provided.

@grape-bot
Copy link

grape-bot commented Jun 1, 2017

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#271](https://github.com/ruby-grape/grape-entity/pull/271): Use latest rubies in ci - [@takkanm](https://github.com/takkanm).

Generated by 🚫 danger

.travis.yml Outdated
- rvm: 2.2.7
- rvm: ruby-head
- rvm: jruby-9.1.6.0
- rvm: jruby-9.1.9.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot …

Copy link
Member

@LeFnord LeFnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @takkanm … please use jruby-9.1.10.0 as @koic suggested

@takkanm
Copy link
Contributor Author

takkanm commented Jun 1, 2017

I updated.

@coveralls
Copy link

coveralls commented Jun 1, 2017

Coverage Status

Coverage remained the same at 92.72% when pulling ea25bbf on takkanm:patch-1 into 5a129b5 on ruby-grape:master.

@LeFnord LeFnord merged commit 7a57525 into ruby-grape:master Jun 1, 2017
@LeFnord
Copy link
Member

LeFnord commented Jun 1, 2017

thanks @takkanm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants