Skip to content

Conversation

steiley
Copy link

@steiley steiley commented Jun 14, 2025

Related to #1489

Rails/HttpPositionalArguments is subject to correction of parameters for RSpec filters, so user is able to allow by key name in this change.

# AllowedKeys: [] (default) # # bad # # get :new, foo: 'bar' #  # AllowedKeys: ['foo']  # # good # # get :new, foo: 'bar'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
@steiley steiley force-pushed the add-new-allowedkeys-to-railshttppositionalarguments branch 4 times, most recently from 12c642f to 19f56d1 Compare June 14, 2025 04:33
@steiley steiley changed the title Add New AllowedKeys to Rails/HttpPositionalArguments Add New AllowedKeys to Rails/HttpPositionalArguments Jun 14, 2025
@steiley steiley force-pushed the add-new-allowedkeys-to-railshttppositionalarguments branch from 19f56d1 to 9c53832 Compare June 14, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants