Skip to content

Conversation

povilasjurcys
Copy link

@povilasjurcys povilasjurcys commented Aug 2, 2023

This PR solves #368 issue by adding DelegatePrivate cop. This cop ensures that private: true is used when delegating methods in private is skipped in public scope. Here are more cases:

# bad class Foo def bar=Bar.new private delegate :baz, to: :bar end # bad class Foo delegate :baz, to: :bar, private: true def bar=Bar.new end # good class Foo def bar=Bar.new private delegate :baz, to: :bar, private: true end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
@povilasjurcys povilasjurcys force-pushed the add_delegate_private_cop branch 3 times, most recently from 3362967 to 72401e5 Compare August 2, 2023 07:11
@povilasjurcys povilasjurcys force-pushed the add_delegate_private_cop branch from 72401e5 to 6958079 Compare August 2, 2023 09:11
expect_offense(<<~RUBY)
class User
delegate :name, to: :user, private: true
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ private `delegate` should be put in private section
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that layout issues and functional issues are mixed together. By focusing solely on functionality, this cop's purpose and role become simpler, so allowing this case would be preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants