Skip to content

Conversation

@olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Apr 14, 2019

This PR updates the CI matrix:


Build failures

Issues dealt with:

  • Update ZenTest to a newer version compatible with RubyGems 3.0.0+
  • Use Ruby 2.5+ with Rails 6
  • Rails 5.0.7.2, Ruby 2.3: Gem::LoadError: can't activate sqlite3 (~> 1.3.6), already activated sqlite3-1.4.0. Make sure all dependencies are added to Gemfile.
  • Rails 4.2.11.1, Ruby 2.4: Same.
  • Rails 3: Same, for sqlite ~> 1.3.5

The build failures about sqlite3 are explained in this StackOverflow thread.

@JonRowe
Copy link
Member

JonRowe commented Apr 16, 2019

Don't suppose you care to try to tackle the build failures? I know they're unrelated!

@olleolleolle
Copy link
Contributor Author

@JonRowe I'm doing it, burning cycles like mad.

@olleolleolle
Copy link
Contributor Author

olleolleolle commented Apr 16, 2019

💚 @JonRowe Could you take a look and see how you find the change?

Question: Should we update to newer patch versions of Ruby in this change? Answer: Since you are on the other side of the globe, I added 2.6.2, 2.5.5, 2.4.6 where applicable.

@olleolleolle olleolleolle changed the title CI: Drop unused setting CI: Drop unused setting, update build matrix, resolve version-specific depdendencies Apr 16, 2019
@JonRowe JonRowe merged commit fb0e4ac into rspec:master Apr 16, 2019
@JonRowe
Copy link
Member

JonRowe commented Apr 16, 2019

thanks 💚

@olleolleolle olleolleolle deleted the patch-1 branch April 16, 2019 16:43
@olleolleolle
Copy link
Contributor Author

Hooray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants