Skip to content

Make it Hapi 17 compatible #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Aconradty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make it Hapi 17 compatible #4

Aconradty wants to merge 1 commit into from

Conversation

@Aconradty
Copy link

@Aconradty Aconradty commented Jan 2, 2018

Hapi's breaking changes => hapijs/hapi#3658
Fast merge would be appreciated !
@phenomax
Copy link

phenomax commented Jan 30, 2018

+1
1 similar comment
@Elpayet
Copy link

Elpayet commented Dec 15, 2018

+1
@Elpayet
Copy link

Elpayet commented Dec 15, 2018 •
edited
Loading

Seems like the PR has somehow already been merged. Adding a name when registrating the plugin may still be necessary:

await app.register({ plugin : { name : 'graphiqlHapiPlugin', register: graphiqlPlugin.plugin.register }, options: { ...<plugin options here> } })
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Aconradty @phenomax @Elpayet