This repository was archived by the owner on Dec 3, 2018. It is now read-only.
fix(bs-loader): actually use suffix when building js file path #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 🤔 getting a bunch of those errors when trying to run the tests locally. Any idea what's wrong?
|
This was referenced Dec 25, 2017
rrdelaney approved these changes Dec 31, 2017
| Thanks for doing this 😄 Must have been left out when adding support for it. Sorry this took so long to get back to, I was taking a quick break from OSS over the holidays |
| No worries, it wasn’t blocking me or anything 😉 |
| Just realized I never published this, it's now on npm as version |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Apparently this was forgotten in #36 😅