Make it easier to view and change the timezone #408
Conversation
Signed-off-by: John Blischak <jdblischak@gmail.com>
Signed-off-by: John Blischak <jdblischak@gmail.com>
Signed-off-by: John Blischak <jdblischak@gmail.com>
Signed-off-by: John Blischak <jdblischak@gmail.com>
Signed-off-by: John Blischak <jdblischak@gmail.com>
| R/checkout.R:160:1: style: functions should have cyclomatic complexity of less than 15, this has 21. checkout <- function(object = NULL, ^R/config.R:56:1: style: functions should have cyclomatic complexity of less than 15, this has 18. config <- function(repo = NULL, global = FALSE, user.name, user.email, ...) { ^R/time.R:52:1: style: Lines should not be more than 80 characters. as.character.git_time <- function(x, tz = "GMT", origin = "1970-01-01", usetz = TRUE, ...) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/time.R:53:1: style: Lines should not be more than 80 characters. as.character(format(as.POSIXct(x, tz = tz, origin = origin), usetz = usetz), ...) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/time.R:58:1: style: Lines should not be more than 80 characters. format.git_time <- function(x, tz = "GMT", origin = "1970-01-01", usetz = TRUE, ...) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/time.R:70:1: style: Lines should not be more than 80 characters. print.git_time <- function(x, tz = "GMT", origin = "1970-01-01", usetz = TRUE, ...) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/time.R:71:1: style: Lines should not be more than 80 characters. cat(sprintf("%s\n", as.character(x, tz = tz, origin = origin, usetz = usetz, ...))) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/when.R:49:1: style: Lines should not be more than 80 characters. return(as.character(object$author$when, tz = tz, origin = origin, usetz = usetz)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/when.R:51:1: style: Lines should not be more than 80 characters. return(as.character(object$when, tz = tz, origin = origin, usetz = usetz)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/when.R:53:1: style: Lines should not be more than 80 characters. return(as.character(object$stasher$when, tz = tz, origin = origin, usetz = usetz)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/when.R:55:1: style: Lines should not be more than 80 characters. return(as.character(object$tagger$when, tz = tz, origin = origin, usetz = usetz)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~tests/time.R:34:1: style: Lines should not be more than 80 characters. stopifnot(identical(as.POSIXct(git_t, tz = "Europe/Stockholm", origin = "1980-02-02"), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~tests/time.R:35:1: style: Lines should not be more than 80 characters. as.POSIXct(1395567947, tz = "Europe/Stockholm", origin = "1980-02-02"))) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~tests/time.R:38:1: style: Lines should not be more than 80 characters. stopifnot(identical(as.character(git_t, tz = "Europe/Stockholm", origin = "1980-02-02"), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~tests/time.R:40:1: style: Lines should not be more than 80 characters. stopifnot(identical(as.character(git_t, tz = "Europe/Stockholm", origin = "1980-02-02", usetz = FALSE), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~tests/time.R:45:1: style: Lines should not be more than 80 characters. utils::capture.output(print(git_t, tz = "Europe/Stockholm", origin = "1980-02-02")), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~tests/time.R:49:1: style: Lines should not be more than 80 characters. utils::capture.output(print(git_t, tz = "Europe/Stockholm", origin = "1980-02-02", usetz = FALSE)), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| Thanks for all your work to fix the git_time issue and improving the documentation 🥇 |
4 participants
This PR is to address Issue #407. It was difficult for me to investigate the time issue because 1)
print.git_timeremoved the timezone, 2)as.POSIXct.git_timehard-coded the timezone, and 3) thegit_timeclass wasn't documented.This PR 1) includes the timezone by default when coercing a
git_timeobject, with the option to remove it withusetz = FALSE, 2) enablesas.POSIXct.git_timeand the other coercing functions to accept user input fortzandorigin, and 3) creates a man page for?git_time.