Use express-async-handler in example #54
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Express does not support async middlware. This PR uses
express-async-handler
to wrap the the async middleware in the example in the README to avoid confusion.If you use unwrapped async middleware in express and an error occurs in the middleware, the request will hang and an
UnhandledPromiseRejectionWarning
will fire.However, if you wrap the async middleware with
express-async-handler
, errors are handled as expected.Note that
koa
supports async middleware natively.