Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/commonjs/src/dynamic-modules.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { existsSync, readFileSync, statSync } from 'fs';
import { join, resolve, dirname } from 'path';
import { join, resolve, dirname, relative } from 'path';

import getCommonDir from 'commondir';

Expand Down Expand Up @@ -46,7 +46,7 @@ export function getDynamicRequireModules(patterns, dynamicRequireRoot) {
.withBasePath()
.withDirs()
.glob(isNegated ? pattern.substr(1) : pattern)
.crawl()
.crawl(relative('.', dynamicRequireRoot))
.sync()
.sort((a, b) => a.localeCompare(b, 'en'))) {
const resolvedPath = resolve(path);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
function takeModule(path) {
// eslint-disable-next-line global-require,import/no-dynamic-require
return require(path);
}

takeModule('../outer.js');
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = 'outer_export_value';
23 changes: 23 additions & 0 deletions packages/commonjs/test/test-dynamic-require-root-outside-cwd.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
const path = require('path');

const test = require('ava');
const { rollup } = require('rollup');

const { commonjs } = require('./helpers/util.js');

process.chdir(path.join(__dirname, 'fixtures/samples/dynamic-require-root-outside-cwd/cwd'));

test('crawls dynamicRequireRoot outside cwd', async (t) => {
const build = await rollup({
input: 'main.js',
plugins: [
commonjs({
dynamicRequireRoot: '..',
dynamicRequireTargets: ['../outer.js']
})
]
});
const bundle = await build.generate({ format: 'cjs' });
const { code } = bundle.output[0];
t.true(code.includes('outer_export_value'), 'outer_export_value not found in the code');
});