Skip to content

Use Selenium's select class for index-based option selecting. This seems... #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Use Selenium's select class for index-based option selecting. This seems... #31

wants to merge 2 commits into from

Conversation

@hhakkala
Copy link

@hhakkala hhakkala commented Jan 9, 2012

... to help with performance issues with selecting elements from large singe-select lists.
Heikki Hakkala added 2 commits January 9, 2012 10:15
@j1z0
Copy link
Contributor

j1z0 commented Feb 15, 2012

I agree with you that the select class will speed things up, but your change breaks the acceptance tests.... to properly use the Select class you probably need to refactor the entire _selectelement class. Otherwise it will be quite confusing as to why some functions use the Select class and others don't, plus you won't really get the speed advantages either.

So if anybody wants to volunteer to do this.. that would be awesome. :)
@j1z0
Copy link
Contributor

j1z0 commented Mar 6, 2012

Heikki,

This issue has been fixed by Ed's latest commit. So I'm closing this request.

Thanks,
Jeremy
@j1z0 j1z0 closed this Mar 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@hhakkala @j1z0