Skip to content

Conversation

@jouk0
Copy link
Contributor

@jouk0 jouk0 commented Dec 20, 2011

... it brakes my tests without it :)

…f041df22114f7c3a0d3e5e314ced35ad54/src/Selenium2Library/keywords/_browsermanagement.py
@j1z0
Copy link
Contributor

j1z0 commented Jan 17, 2012

Hi Jouk0 can you add some tests around the iFrame locator functionality change? If so I think it's OK to merge.

Thanks,
Jeremy

@adwu73
Copy link
Contributor

adwu73 commented Jan 18, 2012

I don't know how to add test yet, so I will learn from Jouko this time, Tks!

Adam

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This get_text is fine I'll go ahead and add it to the base, I'm not sure about the iFrame stuff though. Ed / Ryan any thought on the iFrame stuff?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the iFrame related code in my real projects. They works fine, and the logic is very simple. Please merge into base as well, tks!

@j1z0
Copy link
Contributor

j1z0 commented Mar 15, 2012

Can u guys checkout the Iframes branch and see if works for u.

@qitaos
Copy link
Contributor

qitaos commented May 19, 2012

i will try it.

@jollychang
Copy link
Contributor

any updates?

@alistair-broomhead
Copy link

Any updates? I need to be able to do Get Text for some of my tests, unless anyone has a workaround

@emanlove
Copy link
Member

@alistair-broomhead, @jollychang: I've cherry-picked out the 'get text' patch here and am having @j1z0 review it. Should be merged in soon.

@j1z0
Copy link
Contributor

j1z0 commented Jun 30, 2012

merged. :)
On Jun 30, 2012, at 8:59 AM, Ed Manlove wrote:

@alistair-broomhead, @jollychang: I've cherry-picked out the 'get text' patch here and am having @j1z0 review it. Should be merged in soon.


Reply to this email directly or view it on GitHub:
#21 (comment)

@j1z0
Copy link
Contributor

j1z0 commented Jun 30, 2012

I'm closing this issues as the cherry-picked version from @emanlove has been merged into master

@j1z0 j1z0 closed this Jun 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

7 participants