Skip to content

Conversation

@DanielPBak
Copy link
Contributor

Self-explanatory. The example here is incorrect, I have fixed it.

Copy link
Contributor

@aaltat aaltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug in the documentation. I would actually change the criteria and strategy to locator. Please note that strategy is referenced at least once in the chapter and that actually should be changed also. Would you be willing to make this change?

@aaltat
Copy link
Contributor

aaltat commented Aug 15, 2018

Thanks for pointing out the error. I did have an improvement idea, would you be willing to do what I did suggest in the comment?

@DanielPBak
Copy link
Contributor Author

Sure!

@DanielPBak
Copy link
Contributor Author

I have implemented the changes you requested :)

Copy link
Contributor

@aaltat aaltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaltat
Copy link
Contributor

aaltat commented Aug 20, 2018

Sorry for the long delay. It looks ok in the example level, but you missed a word in few lines below. Could you fix that one too?

@aaltat aaltat merged commit 5efbc6b into robotframework:master Aug 20, 2018
@aaltat
Copy link
Contributor

aaltat commented Aug 20, 2018

Thanks for the contribution. If you want, you can add your name to: https://github.com/robotframework/SeleniumLibrary/blob/master/CHANGES.rst

@DanielPBak
Copy link
Contributor Author

Sure! #1178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants