Skip to content

fix(@rjsf/antd): Add required dependencies explicitly which are installed implicitly #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 16, 2023
Merged

fix(@rjsf/antd): Add required dependencies explicitly which are installed implicitly #3506

merged 6 commits into from
Mar 16, 2023

Conversation

@siketyan
Copy link
Contributor

@siketyan siketyan commented Mar 15, 2023

Reasons for making this change

Can not build a project using @rjsf/antd on Yarn v3 Berry:

ERROR in ../../.yarn/__virtual__/@rjsf-antd-virtual-4fde1b4f37/0/cache/@rjsf-antd-npm-5.2.0-72819c17e5-5a2cf30287.zip/node_modules/@rjsf/antd/dist/antd.esm.js 7:0-36 Module not found: Error: Can't resolve 'classnames' in '[REDACTED]/.yarn/__virtual__/@rjsf-antd-virtual-4fde1b4f37/0/cache/@rjsf-antd-npm-5.2.0-72819c17e5-5a2cf30287.zip/node_modules/@rjsf/antd/dist' @ [REDACTED] ERROR in ../../.yarn/__virtual__/@rjsf-antd-virtual-4fde1b4f37/0/cache/@rjsf-antd-npm-5.2.0-72819c17e5-5a2cf30287.zip/node_modules/@rjsf/antd/dist/antd.esm.js 20:0-42 Module not found: Error: Can't resolve 'lodash-es/isObject' in '[REDACTED]/.yarn/__virtual__/@rjsf-antd-virtual-4fde1b4f37/0/cache/@rjsf-antd-npm-5.2.0-72819c17e5-5a2cf30287.zip/node_modules/@rjsf/antd/dist' @ [REDACTED] ERROR in ../../.yarn/__virtual__/@rjsf-antd-virtual-4fde1b4f37/0/cache/@rjsf-antd-npm-5.2.0-72819c17e5-5a2cf30287.zip/node_modules/@rjsf/antd/dist/antd.esm.js 22:0-42 Module not found: Error: Can't resolve 'lodash-es/isString' in '[REDACTED]/.yarn/__virtual__/@rjsf-antd-virtual-4fde1b4f37/0/cache/@rjsf-antd-npm-5.2.0-72819c17e5-5a2cf30287.zip/node_modules/@rjsf/antd/dist' @ [REDACTED] ERROR in ../../.yarn/__virtual__/@rjsf-antd-virtual-4fde1b4f37/0/cache/@rjsf-antd-npm-5.2.0-72819c17e5-5a2cf30287.zip/node_modules/@rjsf/antd/dist/antd.esm.js 25:0-62 Module not found: Error: Can't resolve 'rc-picker/es/generate/dayjs' in '[REDACTED]/.yarn/__virtual__/@rjsf-antd-virtual-4fde1b4f37/0/cache/@rjsf-antd-npm-5.2.0-72819c17e5-5a2cf30287.zip/node_modules/@rjsf/antd/dist' @ [REDACTED]

This occurs because @rjsf/antd does not declare some dependencies that is required and used in the code. To fix that, this pull request adds the missing dependency explicitly.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature
@heath-freenome heath-freenome merged commit c3ab95c into rjsf-team:main Mar 16, 2023
@siketyan siketyan deleted the build/move-dependencies branch March 17, 2023 01:01
heath-freenome added a commit that referenced this pull request Mar 17, 2023
@heath-freenome
Prepare to release 5.3.0
c7028d4 
- Updated `CHANGELOG.md` to reflect change made in #3506 - Bumped all minor and patch releases of packages in all `package.json` files
@heath-freenome heath-freenome mentioned this pull request Mar 17, 2023
Merged
8 tasks
heath-freenome added a commit that referenced this pull request Mar 17, 2023
@heath-freenome
Release 5.3.0 (#3514)
fc3f4b9 
* Prepare to release 5.3.0 - Updated `CHANGELOG.md` to reflect change made in #3506 - Bumped all minor and patch releases of packages in all `package.json` files * v5.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@siketyan @mpyw @heath-freenome