Adds prop topBar for hiding display of Topbar #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| LGTM. I'm not too sure about the Also this deserves some documentation in the README. |
| Thanks, this is a great patch. Much appreciated 👍 |
| No problem. Glad to able to contribute. |
n1k0 added a commit that referenced this pull request Jul 11, 2016
* Introduce the showErrorList prop for hiding the top error list (#269)
| Released in v0.38.0. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I added a property topBar to allow the toggle of the Error message bar to be hidden along with some test. Issue 251 had also mentioned having the option of setting the top bar hidden.