Update 3.x upgrade guide.md #2436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jimmycallin approved these changes Jun 27, 2021
| Yes, this is basically right. The normal theme didn't have an id for the help field at all previously but the semantic-ui theme had a bug where the id for the help was the id of the field itself. |
epicfaace added a commit that referenced this pull request Jun 28, 2021
Clarify based on #2436 (comment)
| Thanks for the clarification! |
epicfaace added a commit that referenced this pull request Jul 18, 2021
Clarify based on #2436 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Update upgrade guide to encompass changes in #2360. @bradhugh can you also take a look to ensure this is accurate?