Fix crashing when arrayfield has a formdata set to null #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
TheRealJon added a commit to TheRealJon/console that referenced this pull request Dec 2, 2020
In some cases, an uncaught exception could be thrown from dynamically generated array form fields. This was happening when a nested array field had an explicitly set 'null' value. This is a workaround that adds a fallback value to object and array fields to prevent this runtime error. An issue and fix have also been opened upstream in the react-jsonschema-form repo. rjsf-team/react-jsonschema-form#2153 rjsf-team/react-jsonschema-form#2154
TheRealJon changed the title 
…schema-form into TheRealJon-issue-2135
epicfaace approved these changes Jan 29, 2021
epicfaace changed the title This was referenced Jan 29, 2021
| 👋 Thanks for the library and the fix! Would it be possible to make a new release with this fix? |
| Sure thing. |
| Thanks for your time @epicfaace ❤️ |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixed edge case in ArrayField component that would sometimes cause a runtime error. Fixes #2153
Checklist