Skip to content

fix: update arrays correctly when changing index #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2019
Merged

fix: update arrays correctly when changing index #1485

merged 1 commit into from
Nov 9, 2019
+18 −0

Conversation

@SuriGill
Copy link
Contributor

@SuriGill SuriGill commented Oct 16, 2019 •
edited
Loading

Reasons for making this change

SchemaField needs to be updated when items are removed or repositioned in the array with the correct indices. If the index is not passed down from ArrayField, shouldComponentRender in SchemaField returns false as it detects nothing has changed for the array children.

[Please describe them here]
fixes #1479

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature
@epicfaace epicfaace self-assigned this Nov 9, 2019
@epicfaace
Copy link
Member

Thanks @SuriGill !
@epicfaace epicfaace merged commit a6eff3f into rjsf-team:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@SuriGill @epicfaace