Skip to content

Pass registry to ArrayFieldTemplate #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2019
Merged

Pass registry to ArrayFieldTemplate #1317

merged 2 commits into from
Jun 18, 2019

Conversation

@epicfaace
Copy link
Member

Reasons for making this change

Fixes #1113

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature
@epicfaace epicfaace requested a review from edi9999 June 11, 2019 04:30
@edi9999
Copy link
Collaborator

edi9999 commented Jun 11, 2019

Can you add a test for this ?

You've described your use case here : #1113 (comment), can you add it in form of a test ?
@epicfaace
Copy link
Member Author

@edi9999 added it, thanks
@edi9999 edi9999 merged commit 1f6758c into master Jun 18, 2019
@epicfaace epicfaace deleted the fix/registry-aft branch June 18, 2019 14:03
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@epicfaace @edi9999