Skip to content
This repository was archived by the owner on May 10, 2018. It is now read-only.

Conversation

@MemberSense
Copy link

added demo at the end of the index.html

@revolunet
Copy link
Owner

Thanks.
Cant you use scope[iAttributes.rnCarouselOnInfiniteScrollRight]() instead of eval("scope." + iAttributes.rnCarouselOnInfiniteScrollRight) ?

Or even better, use $parse(iAttributes.rnCarouselOnInfiniteScrollRight)(scope) ?

@revolunet
Copy link
Owner

also please remove the console.log

revolunet pushed a commit that referenced this pull request Jun 8, 2015
End to End Swiping & Set of images
@revolunet revolunet merged commit d2a7fe9 into revolunet:master Jun 8, 2015
@revolunet
Copy link
Owner

thanks and sorry for the delay

@MemberSense
Copy link
Author

Thanks! Any thoughts on when an Angular 2 version of the carousel will be
created?

We ended up shifting over to jQuery Slick Carousel:

http://kenwheeler.github.io/slick/

On Mon, Jun 8, 2015 at 5:43 PM, Julien Bouquillon notifications@github.com
wrote:

thanks and sorry for the delay


Reply to this email directly or view it on GitHub
#317 (comment)
.

@revolunet
Copy link
Owner

i won't be able to work on this but i hope some contributors will :)

@revolunet
Copy link
Owner

and yes, slick is awesome

@MemberSense
Copy link
Author

Did you see that we also created a demo at the end of the page. It's not
showing at : http://blog.revolunet.com/angular-carousel/

On Mon, Jun 8, 2015 at 5:43 PM, Julien Bouquillon notifications@github.com
wrote:

thanks and sorry for the delay


Reply to this email directly or view it on GitHub
#317 (comment)
.

@revolunet
Copy link
Owner

sorry, done, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants