Skip to content

feat: build with melange #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

feat: build with melange #61

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0716f99
Port code to ReasonML
andywhite37 Apr 21, 2023
a38e2a4
Merge pull request #1 from qwickshifts/reason-conversion
andywhite37 May 10, 2023
6079ece
Add example from reason-react-native 0.63.0 template
andywhite37 May 10, 2023
db2d5f6
A few fixes
andywhite37 May 11, 2023
d5cd699
Trying to get example working
andywhite37 May 11, 2023
4648aaf
Extreme hacking and version fudging to get it to work
andywhite37 May 11, 2023
6a444e5
screenProps record type
andywhite37 May 11, 2023
ffd5398
Example of accessing route params
andywhite37 May 15, 2023
69ceeae
README
andywhite37 May 15, 2023
c68741c
feat: melange build
anmonteiro May 15, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
README
  • Loading branch information
@andywhite37
andywhite37 committed May 15, 2023
commit 69ceeaece4577a17e7f848c1db2d2828708b4eca
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,10 @@ There is also not a newer version of `reason-react-native` - the newer version o

## Port Status

The code is ported and compiling, but I'm not sure if it works correctly at this point.
The code is ported and compiling, and there is an example that appears to be working.

There are a couple interesting things going on with the `Interop` module and some module unpacking in a few of the modules.

There were a lot of `#` string style polymorphic variants in the Rescript code. I changed these to normal polymorphic variants in the Reason code, but we might need to do something to make them convert to strings in the JS code.

## Example

The `example/` directory was based on this version of an old `reason-react-native` template: https://github.com/rescript-react-native/template/tree/0.63.0
Expand Down