This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Change char payload #709
Merged
Change char payload #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bobzhang reviewed Oct 28, 2022
| let constant f = function | ||
| | Pconst_char i -> pp f "%C" i | ||
| | Pconst_char i -> pp f "%C" (Char.unsafe_chr i) (* todo: consider safety *) | ||
| | Pconst_string (i, None) -> pp f "%S" i |
butterunderflow commented Oct 28, 2022
| | Pconst_char c -> | ||
| let str = | ||
| match c with | ||
| match Char.unsafe_chr c with |
There was a problem hiding this comment.
There's still a unsafe_char usage, but I think this one is safe because it's just value testing and no I/O is involved.
There was a problem hiding this comment.
It seems okay, but there may be some duplication with string_of_int_as_char, you may do a clean up later after this commit landed
57 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Cooperative PR with rescript-lang/rescript#5759