Skip to content

TypedArray docstrings #7984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 23, 2025
Merged

TypedArray docstrings #7984

merged 4 commits into from
Oct 23, 2025

Conversation

fhammerschmidt
Copy link
Member

Part of #7546
@fhammerschmidt fhammerschmidt mentioned this pull request Oct 23, 2025
Open
85 tasks
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 23, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7984

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7984

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7984

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7984

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7984

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7984

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7984

commit: 4e22a37
mediremi
mediremi reviewed Oct 23, 2025
View reviewed changes
mediremi
mediremi reviewed Oct 23, 2025
View reviewed changes
@mediremi
Copy link
Member

Thanks for updating the function descriptions for get and set 👍

The TypedArray.prototype.at and TypedArray.prototype.set MDN links still need to be removed from get and set, and then this PR is good to merge
@fhammerschmidt fhammerschmidt merged commit 372ee8d into master Oct 23, 2025
25 checks passed
@fhammerschmidt fhammerschmidt deleted the typed-array-docstrings branch October 23, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@fhammerschmidt @mediremi