Skip to content

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Aug 26, 2025

Artifact list is now a JSON file that can contain the list of file names for multiple packages.

@nojaf
Copy link
Member

nojaf commented Aug 26, 2025

Would you mind dropping a line or two in https://github.com/rescript-lang/rescript/blob/master/CONTRIBUTING.md maybe?

Why this exists, when it’s relevant, and which commands to run (and when).

@cknitt cknitt marked this pull request as draft August 29, 2025 08:59
@cknitt
Copy link
Member Author

cknitt commented Aug 29, 2025

Would you mind dropping a line or two in https://github.com/rescript-lang/rescript/blob/master/CONTRIBUTING.md maybe?

Why this exists, when it’s relevant, and which commands to run (and when).

Yes, I can do that, but the PR does not build yet anyway, will revisit this later.

@cknitt
Copy link
Member Author

cknitt commented Aug 30, 2025

@cknitt cknitt changed the title Include the contents of @rescript/runtime in the artifact list Fix contents of @rescript/runtime and include it in artifact list Aug 30, 2025
@cknitt cknitt force-pushed the artifact-list branch 2 times, most recently from c4b593f to d6db6b3 Compare August 30, 2025 06:51
@cknitt cknitt marked this pull request as ready for review August 30, 2025 07:06
Copy link

pkg-pr-new bot commented Aug 30, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7810 

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7810 

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7810 

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7810 

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7810 

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7810 

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7810 

commit: 4cf864a

@fhammerschmidt
Copy link
Member

fhammerschmidt commented Aug 30, 2025

Would you add `

"keywords": [ "rescript" ]

to the runtime's package.json so it gets picked up by the package index?

@cknitt
Copy link
Member Author

cknitt commented Aug 30, 2025

@fhammerschmidt We don't have that for the binary packages either though?

Let's maybe just merge and do any further improvements later?

@fhammerschmidt
Copy link
Member

It was in @rescript/std
Not sure if the transitive binary packages should be even listed.

@cknitt
Copy link
Member Author

cknitt commented Aug 30, 2025

The runtime package is also transitive. Anyway, this is not in scope of this PR.

@cknitt cknitt merged commit 85ef7d6 into master Aug 30, 2025
25 checks passed
@cknitt cknitt deleted the artifact-list branch August 30, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants