Skip to content

Use more optional args in stdlib and deprecate some functions #7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

Use more optional args in stdlib and deprecate some functions #7730

merged 2 commits into from
Jul 28, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jul 28, 2025 •
edited
Loading

Closes #7597
@cknitt cknitt force-pushed the stdlib-deprecations branch from b72f335 to 3b3a3b1 Compare July 28, 2025 15:26
@cknitt cknitt force-pushed the stdlib-deprecations branch from 3b3a3b1 to 87ad686 Compare July 28, 2025 15:39
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 28, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7730

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7730

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7730

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7730

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7730

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7730

commit: d40a8bb
@cknitt cknitt requested a review from zth July 28, 2025 16:25
zth
zth approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

After this is merged, could you PR it into #7693 as well, and add proper migrations + tests for the deprecated stuff in this PR? That'll be a good test for the migration work done so far, if that succeeds.
@cknitt cknitt merged commit 118294a into master Jul 28, 2025
27 checks passed
@cknitt cknitt deleted the stdlib-deprecations branch July 28, 2025 17:26
@cknitt
Copy link
Member Author

cknitt commented Jul 29, 2025

After this is merged, could you PR it into #7693 as well, and add proper migrations + tests for the deprecated stuff in this PR? That'll be a good test for the migration work done so far, if that succeeds.

Can't promise I'll find time for that before my vacation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@cknitt @zth