group Jsx modules #7347
Open
group Jsx modules #7347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cknitt reviewed Mar 18, 2025
runtime/Jsx.res Outdated
| module Event = JsxEvent | ||
| module DOM = { | ||
| type style = DOMStyle.t | ||
| type domRef |
There was a problem hiding this comment.
I think it is problematic that the types defined here (other than style) are different from those in JsxDOM. They should all be aliases.
There was a problem hiding this comment.
JsxDOM.domProps.children is of type Jsx.element, defining a alias here creates a cyclic dependency Jsx.cmj -> JsxDOM.cmj -> Jsx.cmj
Unless we create a file Jsx_common.res to put the common values/types
aspeddro force-pushed the group-jsx-modules branch from 25f43c3 to 668ccb3 Compare 
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
aspeddro commented May 11, 2025
aspeddro force-pushed the group-jsx-modules branch from dfb8221 to 1f70005 Compare cknitt reviewed Jun 21, 2025
| But children passed to this component must be of type: | ||
| [1;33mReact.element[0m [2m(defined as[0m [1;33mJsx.element[0m[2m)[0m | ||
| | ||
| In JSX, all content must be JSX elements. You can convert float to a JSX element with [1;33mReact.float[0m. |
There was a problem hiding this comment.
We are losing the improved error messages here, so it seems that some adjustment to the error handling logic is missing. /cc @zth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Creates a top-level module for
Jsx. It contains the following submodules:Jsx.DOMStyleJsx.EventJsx.DOMDeprecate
JsxDOM.res,JsxDOMStyleandJsxEventWith these changes we can have a section in the sidebar menu for the
Jsxmodule containingDOM,DOMStyleandEvent