Skip to content

Conversation

cometkim
Copy link
Member

Fixed #7162

@cometkim

This comment was marked as resolved.

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! 👍
Could you add a CHANGELOG entry?

Copy link
Member

@mununki mununki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cometkim
Copy link
Member Author

@cknitt I think this could be backported to v11.x.

@cknitt
Copy link
Member

cknitt commented Nov 19, 2024

@cknitt I think this could be backported to v11.x.

Yes, will do backporting in bulk after releasing the next v12 alpha.

@cometkim
Copy link
Member Author

Can it be merged? Or do we need to wait for the CI fix yet?

@cknitt
Copy link
Member

cknitt commented Nov 19, 2024

Can be merged already!

@cometkim cometkim merged commit 92477bd into rescript-lang:master Nov 20, 2024
19 of 21 checks passed
@cometkim cometkim deleted the fix-soft-keyword-mangling branch November 20, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants