Move Core into compiler repo #7108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cknitt force-pushed the core branch 3 times, most recently from 8f39951 to 489a3be Compare ![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Syntax Benchmarks
| Benchmark suite | Current: 01daa07 | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Parse RedBlackTree.res - time/run | 1.2031524866666665 ms | 1.2123143266666667 ms | 0.99 |
Parse RedBlackTree.res - allocs/run | 199057 words | 199057 words | 1 |
Print RedBlackTree.res - time/run | 2.3608493999999998 ms | 2.3104395133333333 ms | 1.02 |
Print RedBlackTree.res - allocs/run | 236403 words | 236403 words | 1 |
Print RedBlackTreeNoComments.res - time/run | 2.14703054 ms | 2.10057036 ms | 1.02 |
Print RedBlackTreeNoComments.res - allocs/run | 249186 words | 249186 words | 1 |
Parse Napkinscript.res - time/run | 38.63837942 ms | 39.28006235333333 ms | 0.98 |
Parse Napkinscript.res - allocs/run | 8670066 words | 8670066 words | 1 |
Print Napkinscript.res - time/run | 71.53132409999999 ms | 77.00100409999999 ms | 0.93 |
Print Napkinscript.res - allocs/run | 9776327 words | 9776327 words | 1 |
Parse HeroGraphic.res - time/run | 5.049344153333333 ms | 5.13472718 ms | 0.98 |
Parse HeroGraphic.res - allocs/run | 1219326 words | 1219326 words | 1 |
Print HeroGraphic.res - time/run | 8.923265433333333 ms | 8.775952553333333 ms | 1.02 |
Print HeroGraphic.res - allocs/run | 1396466 words | 1396466 words | 1 |
This comment was automatically generated by workflow using github-action-benchmark.
cknitt force-pushed the core branch 4 times, most recently from 29f1328 to bc1fee9 Compare cknitt changed the title 
zth approved these changes Oct 20, 2024
cristianoc approved these changes Oct 20, 2024
This was referenced Oct 22, 2024
Merged
| Will things like |
| @smorimoto Belt will still have its option module, but since Core became a thing we recommend using the one from Core (and with this merge the global |
| Got it! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Core e230098
runtime(as subdirs don't work there yet)Core__removed, double underscores replaced by single underscoresPervasivestests.@rescript/coreremoved from playground bundlePervasives_miniwhile building runtime. Otherwise we cannot refer to other modules fromPervasives.resbecause of cyclic dependencies.