Special JSX children error message #7044
Conversation
…hat does not accept children
| @res.jsxComponentProps | ||
| type props<'name> = {name: 'name} | ||
| | ||
| let make = (): props<'name> => {children: ""} |
There was a problem hiding this comment.
I don't get this. Is this really what the transform would output?
Why is the make function returning props? And not React.element?
There was a problem hiding this comment.
No it's not what the transform would output, but it doesn't matter, what matters is that a record of the given type is being created, which is what the transform would do. If we want to make this clearer we could set up a test suite with the transform enabled. But I don't know whether that's cumbersome to do. Do you know?
There was a problem hiding this comment.
@cknitt the problem now is that React itself isn't included. There's a react_ppx folder that does similar tests with the transform and React copied into the project itself. We could mimic that, but that's a larger change.
There was a problem hiding this comment.
@zth I don't think you need React, you can use the Jsx module that comes with the compiler.
E.g. something like
@jsx.component let make = (~name) => Jsx.string(name)should work fine.
There was a problem hiding this comment.
Ok, well, you don't need it in my example, but you are right, you need the externals for the JSX runtime if you want to use JSX.
There was a problem hiding this comment.
@cknitt let's just worry about the actual error message in this PR, and then we can figure out how to set up the React transform for this separately.
3 participants
This special cases the error message you get when you pass
childrento a JSX component that does not accept them. The big reason for special casing just this prop is that passing it is already special cased in the syntax (<div>{React.string("this is children")}</div>) vs passing a regular prop (<div className="this is a regular prop" />).I think this makes it clearer, but I'd love to hear some feedback.
Part of #6975