Skip to content

Fix formatting of props spread for multiline JSX expression #6006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2023
Merged

Fix formatting of props spread for multiline JSX expression #6006

merged 3 commits into from
Feb 16, 2023

Conversation

@ah-yu
Copy link
Contributor

@ah-yu ah-yu commented Feb 14, 2023

Fixes #6002
cknitt
cknitt approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot! 👍
@cknitt
Copy link
Member

cknitt commented Feb 15, 2023

Could you add a CHANGELOG entry?
@ah-yu
Copy link
Contributor Author

ah-yu commented Feb 16, 2023 •
edited
Loading

Could you add a CHANGELOG entry?

Done
@cknitt cknitt merged commit 2cd2228 into rescript-lang:master Feb 16, 2023
@cknitt cknitt mentioned this pull request Feb 16, 2023
Closed
@ah-yu ah-yu deleted the fix-spread-props branch February 17, 2023 01:58
@ah-yu ah-yu mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ah-yu @cknitt