Skip to content

Conversation

@Minnozz
Copy link
Contributor

@Minnozz Minnozz commented Jun 15, 2021

Fixes #5189

@Minnozz Minnozz changed the title Document that Nodejs >=10 is supported and run CI for multiple NodeJS versions Document that NodeJS >=10 is supported and run CI for multiple NodeJS versions Jun 15, 2021
@bobzhang
Copy link
Member

bobzhang commented Jun 15, 2021

The test failure seems to be that in recent node versions, unhandled promises rejections is considered a failure.
It can be ignored temporarily.
I wonder if you can give a meaningful name
currently: ci/circleci:build-test-1 -> ci/circleci:node-v10

Edit: I am also wondering what's the motivation here? In general, rescript is not sensitive to node versions, node is just used as a thin wrapper

@Minnozz
Copy link
Contributor Author

Minnozz commented Jun 15, 2021

I've given the jobs meaningful names.
My motivation was that when I was working on #5181, I accidentally broke rescript_format.js on NodeJS v10 because I imported fs/promises which does not work on older NodeJS versions.
Even though the JavaScript wrapper is only a thin layer, it would be bad if we accidentally break the whole of the ReScript toolchain for a subset of users by making such a mistake as I did.
Of course, which NodeJS versions we want to support exactlyis a decision for the team, but this way we can at least easily verify that it does work on those versions.

@Minnozz Minnozz marked this pull request as ready for review June 15, 2021 12:49
- Document this in CONTRIBUTING.md - Run CI for Node.js 10/12/14/16 on Linux - Run CI for Node.js LTS on macOS - Don't share CircleCI cache between different architectures See warning at https://circleci.com/docs/2.0/caching/
@Minnozz Minnozz force-pushed the circleci-multiple-os-and-node-versions branch from a797c50 to 62328e0 Compare June 16, 2021 05:40
@bobzhang
Copy link
Member

, it would be bad if we accidentally break the whole of the ReScript toolchain

I understand the risk, but it is really low in reality if we only test the CI on the oldest node we support. The thing is that doing CI for all versions brings lots of noise

@Minnozz
Copy link
Contributor Author

Minnozz commented Jun 20, 2021

The last commit in this PR changes the CI to two test environments: linux-node-v10 and macos-node-v10.

@peterpme
Copy link

peterpme commented Nov 3, 2021

👋 since node v12 and v14 are in maintenance mode, should node v12 become the new lowest supported version?

@cristianoc
Copy link
Collaborator

Now stale.

@cristianoc cristianoc closed this Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants