Add unstable_usePrompt #9932
Merged
Add unstable_usePrompt #9932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9ffa109 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chaance approved these changes Jan 18, 2023
There was a problem hiding this comment.
Looks good. Since @brophdawg11 made the PR he definitely has to address all future issues related to this topic on GitHub. By official decree.
This was referenced Jan 18, 2023
| Hi, when will "prompt" be released for react router 6? It's actually the one thing I need in order to migrate to react 18 |
| @tan-ahmed This was published in 6.7.0, check the release notes: https://github.com/remix-run/react-router/releases/tag/react-router%406.7.0 |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add an unstable version of
usePrompt. Behavior gets very weird (and in some cases very wrong across browsers) if users click additional back/forward navigations while a prompt is open and there's nothing we can do about it, but this provides a simpler path than building a customuseBlockermodal/inline-prompt.