fix: handle navigation when browser storage is blocked #14335
Merged
+143 −14
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes: #14325
Fixes navigation errors that occur when browser storage (localStorage/sessionStorage) is blocked for any reason.
(In my case, I confirmed this occurs when “Do not save data” is enabled in Chrome.)
Problem
When users block cookies/storage in their browser settings, React Router v7 throws an unhandled
SecurityError
during client-side navigation, causing the application to show "Application Error" instead of navigating properly.Solution
Added try-catch blocks around sessionStorage access in
fog-of-war.ts
to handle storage access errors,Test Instructions
Manual Testing
Integration Test
Added integration test in
session-storage-denied-test.ts
that simulates blocked storage and verifies navigation still works.Note
Referencing other catch blocks, I did not add any separate logs or similar to the catch block. I simply left a comment.