Normalize dirent
entry path across node versions when generating SRI manifest #13591
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #13590
entry.path
onDirent
is deprecated since a few versions and removed as of Node version 24 nodejs/node#55548https://nodejs.org/docs/latest-v23.x/api/fs.html#direntpath
Since RR declares engines as working with any minor/patch version above 20.x.x - I can’t just directly use the
parentPath
which is recommended now. I normalize it so it works also in few minors that havedirent.path
but don't havedirent.parentPath
. Also a bit of gymnastics for TS is needed because installed version of types for node doesn’t include theparentPath