Skip to content

Respect configured assetsDir for all assets #13173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Respect configured assetsDir for all assets #13173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0894d0
Respect configured assetsDir for all assets
danieltroger Mar 6, 2025
77854d7
Update contributors.yml
danieltroger Mar 6, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- danieltroger
- 0xEddie
- aarbi
- abdallah-nour
Expand Down
2 changes: 1 addition & 1 deletion packages/react-router-dev/vite/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3146,7 +3146,7 @@ export async function getEnvironmentOptionsResolvers(
let routeChunkSuffix = routeChunkName
? `-${kebabCase(routeChunkName)}`
: "";
return `assets/[name]${routeChunkSuffix}-[hash].js`;
return path.join(viteUserConfig.build.assetsDir ?? "assets", `[name]${routeChunkSuffix}-[hash].js`);
},
},
},
Expand Down