Skip to content

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Dec 2, 2024

Fixes #12424

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 941e9e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gustavopch
Copy link

gustavopch commented Dec 2, 2024

@pcattori Note that this won't completely support ESM/nodenext yet regarding the type augmentation of AppLoadContext.

@pcattori
Copy link
Contributor Author

pcattori commented Dec 2, 2024

@pcattori Note that this won't completely support ESM yet regarding the type augmentation of AppLoadContext.

Yep, looking into CJS/ESM types for AppLoadContext type augmentation next as a separate issue. We were already having issues with development/production export conditions, so I wanted to batch the types export stuff with that work.

@pcattori pcattori merged commit d12031c into dev Dec 2, 2024
8 checks passed
@pcattori pcattori deleted the pedro/support-moduleresolution-nodenext branch December 2, 2024 22:57
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🤖 Hello there,

We just published version 7.0.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Dec 3, 2024

🤖 Hello there,

We just published version 7.0.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

nowells pushed a commit to nowells/react-router that referenced this pull request Dec 3, 2024
remix-run#12440 introduced a fix for tsconfig, however, it broke non-JS routes (like .mdx)
nowells pushed a commit to nowells/react-router that referenced this pull request Dec 3, 2024
remix-run#12440 introduced a fix for tsconfig, however, it broke non-JS routes (like .mdx)
nowells pushed a commit to nowells/react-router that referenced this pull request Dec 3, 2024
remix-run#12440 introduced a fix for tsconfig, however, it broke non-JS routes (like .mdx)
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.1.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.3-pre-v6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

nowells pushed a commit to nowells/react-router that referenced this pull request May 27, 2025
…JS routes (like .mdx) When we have a file `./app/routes/test/index.mdx` which is a route we get the following error: ``` .react-router/types/app/routes/test/+types/index.ts:10:29 - error TS2307: Cannot find module ../index.js or its corresponding type declarations. 10 type Module = typeof import("../index.js") ~~~~~~~~~~~~~ ```
nowells pushed a commit to nowells/react-router that referenced this pull request May 27, 2025
…JS routes (like .mdx) When we have a file `./app/routes/test/index.mdx` which is a route we get the following error: ``` .react-router/types/app/routes/test/+types/index.ts:10:29 - error TS2307: Cannot find module ../index.js or its corresponding type declarations. 10 type Module = typeof import("../index.js") ~~~~~~~~~~~~~ ```
nowells pushed a commit to nowells/react-router that referenced this pull request May 27, 2025
…JS routes (like .mdx) When we have a file `./app/routes/test/index.mdx` which is a route we get the following error: ``` .react-router/types/app/routes/test/+types/index.ts:10:29 - error TS2307: Cannot find module ../index.js or its corresponding type declarations. 10 type Module = typeof import("../index.js") ~~~~~~~~~~~~~ ```
nowells pushed a commit to nowells/react-router that referenced this pull request May 27, 2025
…JS routes (like .mdx) When we have a file `./app/routes/test/index.mdx` which is a route we get the following error: ``` .react-router/types/app/routes/test/+types/index.ts:10:29 - error TS2307: Cannot find module ../index.js or its corresponding type declarations. 10 type Module = typeof import("../index.js") ~~~~~~~~~~~~~ ```
pcattori added a commit that referenced this pull request Jun 2, 2025
* #12440 introduced a fix for tsconfig, however, it broke non-JS routes (like .mdx) When we have a file `./app/routes/test/index.mdx` which is a route we get the following error: ``` .react-router/types/app/routes/test/+types/index.ts:10:29 - error TS2307: Cannot find module ../index.js or its corresponding type declarations. 10 type Module = typeof import("../index.js") ~~~~~~~~~~~~~ ``` * Create two-needles-sell.md --------- Co-authored-by: Nowell Strite <nstrite@nvidia.com> Co-authored-by: Pedro Cattori <pcattori@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants