Skip to content

fix: Wait for restore url navigation to complete before proceeding #11930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 27, 2024
Merged

fix: Wait for restore url navigation to complete before proceeding #11930

merged 5 commits into from
Aug 27, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Aug 26, 2024 •
edited
Loading

Copies changes from @Artur- from #11620 but repoints to the v6 branch.

Because this relies on behavior of history which JSDOM doesn't correctly implement - I'm testing this through a Remix E2E test (which will be pulled into this Repo in RR v7): remix-run/remix#9914
@brophdawg11 @Artur-
fix: Wait for restore url navigation to complete before proceeding
8d44dfa 
Co-authored-by: Artur Signell <artur@vaadin.com>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4f435a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
brophdawg11 and others added 2 commits August 26, 2024 14:22
@brophdawg11 @Artur-
Add changeset
db18ae8 
Co-authored-by: Artur Signell <artur@vaadin.com>
@brophdawg11 @Artur-
Update contributors.yml
7d87ffb 
Co-authored-by: Artur Signell <artur@vaadin.com>
@brophdawg11 brophdawg11 linked an issue Aug 26, 2024 that may be closed by this pull request
[Bug]: useBlocker fails when blocking function is quick to proceed #11613
Closed
@brophdawg11 brophdawg11 mentioned this pull request Aug 26, 2024
Closed
@brophdawg11 brophdawg11 merged commit 5651176 into v6 Aug 27, 2024
@brophdawg11 brophdawg11 deleted the brophdawg11/blocker-sync branch August 27, 2024 13:42
This was referenced Aug 27, 2024
Closed
Merged
@tepi tepi mentioned this pull request Sep 4, 2024
Closed
@github-actions github-actions bot mentioned this pull request Sep 4, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

🤖 Hello there,

We just published version 6.26.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!
brophdawg11 added a commit that referenced this pull request Sep 5, 2024
@brophdawg11 @Artur-
fix: Wait for restore url navigation to complete before proceeding (#…
5ff506e 
…11930) Co-authored-by: Artur Signell <artur@vaadin.com>
@github-actions github-actions bot mentioned this pull request Sep 9, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

🤖 Hello there,

We just published version 6.26.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!
@david-crespo david-crespo mentioned this pull request Sep 13, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed

1 participant

@brophdawg11