Move server-runtime to react-router/server #11669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
| Name | Type |
|---|---|
| react-router-dom | Major |
| @react-router/express | Major |
| react-router | Major |
| @react-router/serve | Major |
| @react-router/node | Major |
| @react-router/dev | Major |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
markdalgleish changed the title @react-router/server-runtime to react-router@react-router/server-runtime to react-router/server markdalgleish changed the title @react-router/server-runtime to react-router/serverserver-runtime to react-router/server 
markdalgleish commented Jun 18, 2024
There was a problem hiding this comment.
Note that the existing react-router unit tests have all moved into the lib directory to isolate them from the server tests in terms of Jest config.
| Closing in favour of #11698. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As mentioned in #11646 (comment), I've started looking into this as part of moving the runtime/adapter packages out of the monorepo since it means we likely don't want to re-export the entire server-runtime API from these standalone packages anymore.