Fix partial object (search or hash only) pathnames losing current path #10029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 39eecea The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11 commented Feb 2, 2023
Comment on lines +424 to +428
| if ( | ||
| isBrowser && | ||
| typeof to === "string" && | ||
| /^(?:[a-z][a-z0-9+.-]*:|\/\/)/i.test(to) | ||
| ) { |
There was a problem hiding this comment.
All absolute logic now only happens when to is a string and we use to unaltered as we did before in useHref and useLinkClickHandler for non-absolute URLs
mcansh reviewed Feb 2, 2023
mcansh approved these changes Feb 2, 2023
This was referenced Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Absolute URL detection in
<Link to>missed a case where the object form oftowas used without a pathname, and resulted in the loss of the active pathnameCloses #10007