Skip to content

Conversation

btholt
Copy link
Contributor

@btholt btholt commented May 21, 2015

Went ahead and did it.

  • Added strict mode
  • Updated README.md to reflect the addition
  • Bumped version to 1.1.0 (happy to take that out; just seemed like the right thing to do)
  • Added tests to cover the new functionality
@btholt btholt mentioned this pull request May 21, 2015
@btholt
Copy link
Contributor Author

btholt commented May 21, 2015

Cool. I'll amend my commit so the version number is 1.0.2 here in a bit. I'll leave the restyling of the README to you. 😄

@tunnckoCore
Copy link
Member

@btholt sorry for the delay, i come to it... lol. I'll try to push it up today.

@tunnckoCore tunnckoCore self-assigned this Jun 1, 2015
tunnckoCore added a commit that referenced this pull request Jun 1, 2015
@tunnckoCore tunnckoCore merged commit a39c82e into regexhq:master Jun 1, 2015
@tunnckoCore
Copy link
Member

@btholt hm... is that should return false?

hexColorRegex().test('#123fff}') //=> true, now

/cc @regexps/owners

@tunnckoCore
Copy link
Member

@btholt published as npm@v1.0.2 cuz there's no breaking change

@btholt
Copy link
Contributor Author

btholt commented Jun 1, 2015

Hooray! Thank you!

@tunnckoCore
Copy link
Member

Yea, sorry for the long delay. 🍺

@btholt
Copy link
Contributor Author

btholt commented Jun 1, 2015

No apology necessary. I'm hugely appreciative. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants