Skip to content

Conversation

@green-br
Copy link
Contributor

The example to use Stream seems to use OMP_PROC_BIND but sets possible values as close, cores, spread. This confused me and therefore suggest the following unless I am missing something.

cores does seem to be a valid option for OMP_PROC_BIND and only for OMP_PLACES.

true is a valid option and doesnt enforce a method for affinity. Could also be false to allow threads to migrate.

For example see: https://www.openmp.org/spec-html/5.0/openmpse52.html#x291-20580006.4

Is there another reason why it's set to cores as part of the learning experience? I couldn't see any reference to why it would be.

@vkarak vkarak self-requested a review March 19, 2025 22:18
@vkarak vkarak added this to the ReFrame 4.8 milestone Mar 19, 2025
@vkarak vkarak changed the title Use of OMP_PROC_BIND in example [doc] Use of OMP_PROC_BIND in example Mar 20, 2025
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think the original intent was to set the OMP_PLACES instead and use the "threads", "cores" and "sockets" values to parameterize.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in ReFrame Backlog Mar 20, 2025
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a chat with @victorusu, it's fine to accept it as is. Thanks!

@vkarak vkarak changed the title [doc] Use of OMP_PROC_BIND in example [doc] Use of OMP_PROC_BIND in example Apr 2, 2025
@vkarak vkarak changed the title [doc] Use of OMP_PROC_BIND in example [doc] Use correct OMP_PROC_BIND arguments in the tutorial examples Apr 2, 2025
@vkarak vkarak enabled auto-merge April 2, 2025 21:39
@vkarak vkarak merged commit 68a4edb into reframe-hpc:develop Apr 2, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ReFrame Backlog Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment