Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jan 29, 2025

This PR introduces YAML configuration files and deprecates raw JSON configuration files.

Check the updated docs for more details:

  • docs/config_reference.rst
  • docs/manpage.rst

Closes #3322.

Todos

  • Issue deprecation warning when a JSON configuration file is loaded.
@vkarak vkarak added this to the ReFrame 4.8 milestone Jan 29, 2025
@vkarak vkarak requested review from ekouts, teojgo and victorusu January 29, 2025 18:15
@vkarak vkarak self-assigned this Jan 29, 2025
@vkarak vkarak force-pushed the feat/yaml-config branch 3 times, most recently from c154779 to 72fe599 Compare January 29, 2025 19:12
@vkarak vkarak marked this pull request as draft February 9, 2025 15:21
@vkarak
Copy link
Contributor Author

vkarak commented Feb 9, 2025

I'm converting this PR to draft, since I had some second thoughts on the sh binding. It's safer if we remove it. The same effect could be achieved through an environment variable, but ReFrame will not be executing arbitrary code:

FOO=$(echo "hello") 

and then using getenv("FOO") in the config.

I'm adding some other useful bindings such as username, groupname, uid, and gid.

@vkarak vkarak marked this pull request as ready for review February 9, 2025 20:43
@vkarak vkarak requested a review from teojgo February 9, 2025 20:44
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is awesome! lgtm.

- Introduce also some additional basic bindings
@vkarak vkarak merged commit 26fb0f0 into reframe-hpc:develop Feb 10, 2025
36 checks passed
@vkarak vkarak deleted the feat/yaml-config branch February 10, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment