[bugfix] Improve handling of requests in httpjson logger #3354
Conversation
| raise LoggingError( | ||
| f'logging failed: HTTP response code ' | ||
| f'{response.status_code}' | ||
| ) |
There was a problem hiding this comment.
Should Reframe crash in this case, or try to print a warning?
There was a problem hiding this comment.
How does the outpupt look like when we raise LoggingError? I see that currently we do raise it, but I'm not sure it's the right thing. I would rather go for a warning instead (remember to include the name of the handler in the message).
| raise LoggingError( | ||
| f'logging failed: HTTP response code ' | ||
| f'{response.status_code}' | ||
| ) |
There was a problem hiding this comment.
How does the outpupt look like when we raise LoggingError? I see that currently we do raise it, but I'm not sure it's the right thing. I would rather go for a warning instead (remember to include the name of the handler in the message).
| self._url, data=json_record, | ||
| headers=self._headers | ||
| ) | ||
| if response.status_code == 200: |
There was a problem hiding this comment.
Maybe we should go for the more inclusive:
| if response.status_code == 200: | |
| if response.ok: |
| break | ||
| | ||
| if response.status_code == 429: | ||
| time.sleep(1) |
There was a problem hiding this comment.
Since this can slow down the pipeline what about spreading the wait with a cyclic interval list, say [.1, .2, .4, .8, 1.6, 3.2]?
2 participants
Fixes #3353 .